mimic: mgr/dashboard: Add support for URI encode #24488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tiago Melo <tmelo@suse.com> (cherry picked from commit 44ea474) Conflicts: src/pybind/mgr/dashboard/frontend/src/app/ceph/block/rbd-form/rbd-form.component.ts Had to remove new codew related to permissions src/pybind/mgr/dashboard/frontend/src/app/shared/api/rgw-bucket.service.ts Had to remove code for a new parameter
Created a decorator and pipe to help encode special URI components in the frontend. Modified the backend request handler to decode all the string args. fixes: http://tracker.ceph.com/issues/24621 Signed-off-by: Tiago Melo <tmelo@suse.com> (cherry picked from commit f21d0da) Conflicts: (all paths are relative to src/pybind/mgr/dashboard/) controllers/__init__.py Method where the new code was doesn't exist in mimic, has to put it in another method frontend/src/app/ceph/block/rbd-list/rbd-list.component.html frontend/src/app/ceph/block/rbd-snapshot-list/rbd-snapshot-list.component.html frontend/src/app/ceph/block/rbd-snapshot-list/rbd-snapshot-list.component.spec.ts frontend/src/app/ceph/rgw/rgw-bucket-list/rgw-bucket-list.component.html frontend/src/app/shared/api/pool.service.ts frontend/src/app/shared/api/rbd.service.spec.ts file doesn't exist in mimic frontend/src/app/shared/api/rbd.service.ts frontend/src/app/shared/api/rgw-bucket.service.ts frontend/src/app/shared/api/rgw-daemon.service.ts frontend/src/app/shared/api/rgw-user.service.ts
By enconding all parameters of api services we were also encoding parameters that were being sent in the body of the request. Those parameters don't need to be enconded and the server never decodes them. With this new decorator you can specify if you don't want a parameter to be enconded. This is a regression introduced in f21d0da. Fixes: http://tracker.ceph.com/issues/26856 Signed-off-by: Tiago Melo <tmelo@suse.com> (cherry picked from commit 45e645b) Conflicts: src/pybind/mgr/dashboard/frontend/src/app/shared/api/rbd.service.spec.ts src/pybind/mgr/dashboard/frontend/src/app/shared/api/rbd.service.ts
tspmelo
force-pushed
the
wip-24907-mimic
branch
from
b33ca5a
to
eda4df3
Compare
|
jenkins re-test this please |
|
@tspmelo Why is this DNM? |
|
@smithfarm I was told that #24183 might be backported to mimic. The same applies to #24478. |
tspmelo
changed the title
| @@ -16,6 +16,12 @@ | |||
| import threading | |||
| import types # pylint: disable=import-error | |||
|
|
|||
| if sys.version_info >= (3, 0): | |||
There was a problem hiding this comment.
Funny thing. #24626 contains a better way to import unquote
Suggested change
| if sys.version_info >= (3, 0): | |
| from six.moves.urllib.parse import unquote # pylint: disable=import-error |
But I wouldn't change it in Mimic only.
LenzGr
changed the title
|
Waiting for @rjfd to review/approve. |
tspmelo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: http://tracker.ceph.com/issues/24907