mgr/selftest: fix disabled module selection #24517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnwat
suggested changes
Oct 10, 2018
src/pybind/mgr/selftest/module.py
Outdated
| all_modules = [m['name'] for m in mgr_map['available_modules']] | ||
| disabled_modules = set(all_modules) - set(mgr_map['modules']) | ||
| disabled_module = list(disabled_modules)[0] | ||
| assert disabled_moduled not in mgr_map['modules'] |
There was a problem hiding this comment.
also: presumably the the assert is testing that the module isn't enabled and it isn't always on. might want to test that its not in the union of map['modules'] and map['always_on_modules']
This was broken by always on modules -- it was also unnecessary complication, let's just pick some hardcoded module to use. Signed-off-by: John Spray <john.spray@redhat.com>
|
Good catch, updated |
dotnwat
approved these changes
Oct 11, 2018
|
Merged on strength of a vstart_runner pass, as this was already generating failures in teuthology |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken intermittently by always on modules -- it was also
unnecessary complication, let's just pick some
hardcoded module to use.
Signed-off-by: John Spray john.spray@redhat.com