luminous: tests: qa/workunits: replace 'realpath' with 'readlink -f' in fsstress.sh #24620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: this PR includes the commits from PR #24430 |
|
@dillaman Rebase to get rid of the merge commit? |
Currently git.ceph.com is hardcoded for all cram jobs. Testing modifications is a pain: one needs to push to either ceph/ceph.git or ceph/ceph-ci.git (depending on where the ceph branch is at, triggering unnecessary builds in the latter case) and wait for the mirror to sync. Runs scheduled against branches in developer's forks fail. Move away from git.ceph.com to allow mixing branches and repositories, similar to workunits. Fixes: https://tracker.ceph.com/issues/27211 Signed-off-by: Ilya Dryomov <idryomov@gmail.com> (cherry picked from commit 0d88876) Conflicts: qa/suites/krbd/basic/tasks/krbd_blkroset.yaml qa/suites/krbd/basic/tasks/krbd_huge_image.yaml qa/suites/krbd/basic/tasks/krbd_msgr_segments.yaml qa/suites/krbd/basic/tasks/krbd_parent_overlap.yaml qa/suites/krbd/basic/tasks/krbd_whole_object_discard.yaml - in master, the cram task is referred to in these additional yaml files, but in luminous it's only referred to in qa/suites/krbd/unmap/tasks/unmap.yaml
Allow for reuse in the cram task. Signed-off-by: Ilya Dryomov <idryomov@gmail.com> (cherry picked from commit e1c89b5)
Commit 0d88876 ("qa/tasks/cram: use suite_repo repository for all cram jobs") removed hardcoded git.ceph.com links, but as it turned out it is still used for nightlies. There is no good way to accommodate the different URL schemes, so let's get rid of URLs altogether. Fixes: https://tracker.ceph.com/issues/27211 Signed-off-by: Ilya Dryomov <idryomov@gmail.com> (cherry picked from commit 592f566) Conflicts: qa/suites/krbd/basic/tasks/krbd_blkroset.yaml qa/suites/krbd/basic/tasks/krbd_huge_image.yaml qa/suites/krbd/basic/tasks/krbd_msgr_segments.yaml qa/suites/krbd/basic/tasks/krbd_parent_overlap.yaml qa/suites/krbd/basic/tasks/krbd_whole_object_discard.yaml - in master, the cram task is referred to in these additional yaml files, but in luminous it's only referred to in qa/suites/krbd/unmap/tasks/unmap.yaml
Fixes: http://tracker.ceph.com/issues/36409 Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit ddb7e5e)
This makes it easier to re-run tests against a suite branch without requiring a full ceph-ci build and repo. Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit c1f9502)
Right now it's using the Ceph branch/SHA1 but it's using the suite Git URL. Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 1e3dc02)
dillaman
force-pushed
the
wip-36431-luminous
branch
from
670c3d5
to
9cf7a2b
Compare
|
@smithfarm done |
smithfarm
approved these changes
Oct 19, 2018
There was a problem hiding this comment.
LGTM. From my POV, it can be merged if it passes rbd suite. It also touches the krbd suite and the workunit task, which could potentially have ramifications for all other suites, but we don't need to re-do 12.2.9 QE for this PR, since it doesn't change any code outside of qa/.
smithfarm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/35537
http://tracker.ceph.com/issues/36431