radosgw-admin: translate reshard status codes (trivial) #24638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: http://tracker.ceph.com/issues/36486 Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
|
have a request for something like this downstream; advice on better codes, or to move to_string function to rgw_admin? |
cbodley
approved these changes
Oct 17, 2018
| @@ -612,6 +615,24 @@ enum cls_rgw_reshard_status { | |||
| CLS_RGW_RESHARD_DONE = 2, | |||
| }; | |||
|
|
|||
| static inline std::string to_string(const enum cls_rgw_reshard_status status) | |||
There was a problem hiding this comment.
i like this very much, because it acts as an overload of std::to_string() (which is defined only for integral types) 👍
|
@cbodley thanks casey |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: http://tracker.ceph.com/issues/36486
Signed-off-by: Matt Benjamin mbenjamin@redhat.com