rgw: move keystone secrets from ceph.conf to files #24816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattbenjamin
force-pushed
the
wip-rgw-keystone-secret
branch
2 times, most recently
from
335da1f
to
523cfb9
Compare
|
@cbodley read_secret tested w/input of 9 and 2K |
mattbenjamin
force-pushed
the
wip-rgw-keystone-secret
branch
from
523cfb9
to
0f00726
Compare
|
code looks good. i like the deprecation strategy. could you please update http://docs.ceph.com/docs/master/radosgw/keystone/ to reflect the changes? |
mattbenjamin
force-pushed
the
wip-rgw-keystone-secret
branch
from
0f00726
to
4118faa
Compare
|
@cbodley added doc |
mattbenjamin
force-pushed
the
wip-rgw-keystone-secret
branch
2 times, most recently
from
348325b
to
0ab7cff
Compare
cbodley
reviewed
Nov 2, 2018
mattbenjamin
force-pushed
the
wip-rgw-keystone-secret
branch
from
0ab7cff
to
147727d
Compare
mattbenjamin
force-pushed
the
wip-rgw-keystone-secret
branch
from
147727d
to
e636a56
Compare
Permits setting restrictive permissions on these secrets. Fixes: http://tracker.ceph.com/issues/36621 Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Permits setting restrictive permissions on these secrets.
Fixes: http://tracker.ceph.com/issues/36621
Signed-off-by: Matt Benjamin mbenjamin@redhat.com