mgr/dashboard: Cleanup of OSD list methods #24823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Devp00l
requested review from
tspmelo,
votdev,
alfonsomthd,
p-se,
ricardoasmarques,
epuertat and
s0nea
Devp00l
force-pushed
the
wip-issue-36615
branch
from
f8f95a2
to
a05ed0c
Compare
|
jenkins retest this please |
|
It would be good if you briefly mentioned that this is a cleanup PR, which doesn't fix a bug or implements a feature. |
alfonsomthd
approved these changes
Oct 30, 2018
p-se
requested changes
Oct 31, 2018
src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-list/osd-list.component.spec.ts
Show resolved
Hide resolved
tspmelo
suggested changes
Oct 31, 2018
Some test changes were required, too. Fixes: https://tracker.ceph.com/issues/36615 Signed-off-by: Stephan Müller <smueller@suse.com>
Devp00l
force-pushed
the
wip-issue-36615
branch
from
a05ed0c
to
ff64ffd
Compare
Devp00l
changed the title
|
Addressed all comments |
p-se
approved these changes
Nov 2, 2018
|
jenkins test dashboard |
tspmelo
approved these changes
Nov 5, 2018
tspmelo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed #24606 (comment) , the interface methods should be removed for a cleanup RFC PR.
Fixes: https://tracker.ceph.com/issues/36615
Signed-off-by: Stephan Müller smueller@suse.com