rbd: support namespaces for image migration #24836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trociny
requested changes
Oct 31, 2018
|
@trociny Good catch -- added |
trociny
approved these changes
Oct 31, 2018
|
@trociny fixed |
trociny
reviewed
Nov 1, 2018
| char *source_image_name; | ||
| char *source_image_id; | ||
| int64_t dest_pool_id; | ||
| char *dest_pool_namespace; |
There was a problem hiding this comment.
@dillaman need to update ctypedef struct rbd_image_migration_status_t in rbd.pyx:
zhuzha:~/ceph/ceph.ci/build% RBD_FEATURES=127 PYTHONPATH=../src/test/pybind:../src/pybind:./lib/cython_modules/lib.2 LD_LIBRARY_PATH=./lib nosetests -v test_rbd:TestMigration.test_migration
test_rbd.TestMigration.test_migration ... ERROR
======================================================================
ERROR: test_rbd.TestMigration.test_migration
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/nose/case.py", line 197, in runTest
self.test(*self.arg)
File "/ssd/ceph/ceph.ci/src/test/pybind/test_rbd.py", line 2041, in test_migration
status = RBD().migration_status(ioctx, image_name)
File "rbd.pyx", line 1413, in rbd.RBD.migration_status (/home/mgolub/ceph/ceph.ci/build/src/pybind/rbd/rbd.c:11588)
OSError: [errno 34] error getting migration status
There was a problem hiding this comment.
Fixed -- and just learned that Cython doesn't validate the structs.
Fixes: http://tracker.ceph.com/issues/26951 Signed-off-by: Jason Dillaman <dillaman@redhat.com>
trociny
added a commit
to trociny/ceph
that referenced
this pull request
Nov 2, 2018
…ceph#24836 · ceph/ceph · GitHub * wip-26951: rbd: support namespaces for image migration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: http://tracker.ceph.com/issues/26951
Signed-off-by: Jason Dillaman dillaman@redhat.com