mgr/dashboard: Simplification of PoolForm method #24892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Nawracay <pnawracay@suse.com>
votdev
approved these changes
Nov 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the attribute names and functions off the values in the
transformvariable, as this construct is unnecessarily complex. Also, thepoolvariable is available everywhere in theinitEditFormDatamethod, so no need to pass it as argument to functions. The result is an object which doesn't contain two different types of values, which would have to be parsed to get the real value. Instead they just contain the values without having to parse anything. This simplifies the addition of new and dynamic fields, which are about to be added for QoS management for pools and RBDs.Does also contain name changes of variables.
Signed-off-by: Patrick Nawracay pnawracay@suse.com