librados: cleanups

[tchaikov]

changes from the wishlist in https://pad.ceph.com/p/librados3

[jdurgin]

@dillaman any issues with CephContext or other structures here?

[dillaman]

Yeah -- they need to be version linked (or the cct() method needs to be yanked and we need to figure out a new way to do logging)

[tchaikov]

ahh, i see. we take advantage of the fact that librados::config_t is actually CephContext* in (anonymous_namespace)::get_cct().

[jdurgin]

lgtm aside from the question about librbd exact version dependence

[jdurgin]

looks like the make check failure is real:
../../../lib/librbd_internal.a(internal.cc.o): In function `librbd::tmap_set(librados::IoCtx&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)': /home/jenkins-build/build/workspace/ceph-pull-requests/src/librbd/internal.cc:285: undefined reference to `librados::IoCtx::tmap_update(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, ceph::buffer::list&)' ../../../lib/librbd_internal.a(internal.cc.o): In function `librbd::tmap_rm(librados::IoCtx&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)': /home/jenkins-build/build/workspace/ceph-pull-requests/src/librbd/internal.cc:294: undefined reference to `librados::IoCtx::tmap_update(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, ceph::buffer::list&)' ../../../lib/librbd_internal.a(RenameRequest.cc.o): In function `librbd::operation::RenameRequest<librbd::ImageCtx>::send_update_directory()': /home/jenkins-build/build/workspace/ceph-pull-requests/src/librbd/operation/RenameRequest.cc:175: undefined reference to `librados::ObjectWriteOperation::tmap_update(ceph::buffer::list const&)'

[tchaikov]

http://pulpito.ceph.com/kchai-2018-11-04_15:20:53-rados-wip-kefu-testing-2018-11-03-2239-distro-basic-smithi/

[tchaikov]

retest this please.

[tchaikov]

changelog:

• add a commit to fix the dependency of libradospp-dev: 70a26ed

it should address the failure of http://pulpito.ceph.com/kchai-2018-11-07_07:51:37-rados-wip-kefu2-testing-2018-11-04-1018-distro-basic-smithi/3233734/ , where we have

2018-11-07T08:20:28.949 INFO:tasks.workunit.client.0.smithi158.stdout:The following information may help to resolve the situation:
2018-11-07T08:20:28.949 INFO:tasks.workunit.client.0.smithi158.stdout:
2018-11-07T08:20:28.949 INFO:tasks.workunit.client.0.smithi158.stdout:The following packages have unmet dependencies:
2018-11-07T08:20:28.995 INFO:tasks.workunit.client.0.smithi158.stdout: libradospp-dev : Depends: libradospp (= 14.0.0-4787-g9116858-1bionic) but it is not installable
2018-11-07T08:20:29.011 INFO:tasks.workunit.client.0.smithi158.stderr:E: Unable to correct problems, you have held broken packages.
2018-11-07T08:20:29.013 DEBUG:teuthology.orchestra.run:got remote process result: 100

• add a commit to install libradospp-dev for testing librados*-{dev,devel}

it should address the failure of http://pulpito.ceph.com/kchai-2018-11-07_07:51:37-rados-wip-kefu2-testing-2018-11-04-1018-distro-basic-smithi/3233772/, where we have

2018-11-07T08:59:41.067 INFO:tasks.workunit.client.0.smithi150.stdout:g++ -std=c++11 -Wno-unused-parameter -Wall -Wextra -Werror -g   -o hello_world_cpp hello_world.cc -lrados -lradosstriper
2018-11-07T08:59:41.401 INFO:tasks.workunit.client.0.smithi150.stderr:hello_world.cc:14:10: fatal error: rados/librados.hpp: No such file or directory
2018-11-07T08:59:41.401 INFO:tasks.workunit.client.0.smithi150.stderr: #include <rados/librados.hpp>
2018-11-07T08:59:41.401 INFO:tasks.workunit.client.0.smithi150.stderr:          ^~~~~~~~~~~~~~~~~~~~
2018-11-07T08:59:41.401 INFO:tasks.workunit.client.0.smithi150.stderr:compilation terminated.
2018-11-07T08:59:41.406 INFO:tasks.workunit.client.0.smithi150.stdout:Makefile:29: recipe for target 'hello_world_cpp' failed
2018-11-07T08:59:41.406 INFO:tasks.workunit.client.0.smithi150.stderr:make: *** [hello_world_cpp] Error