Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/rbd_mirror: race in TestMockImageMap.AddInstancePingPongImageTest #24897

Merged
merged 1 commit into from
Nov 2, 2018

Conversation

trociny
Copy link
Contributor

@trociny trociny commented Nov 2, 2018

Remove a context from peer_ack_ctxs before completing to avoid a race
with a listener inserting a new one.

Fixes: http://tracker.ceph.com/issues/36683
Signed-off-by: Mykola Golub mgolub@suse.com

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Remove a context from peer_ack_ctxs before completing to avoid a race
with a listener inserting a new one.

Fixes: http://tracker.ceph.com/issues/36683
Signed-off-by: Mykola Golub <mgolub@suse.com>
@trociny
Copy link
Contributor Author

trociny commented Nov 2, 2018

It was easily reproduced in my env running

./bin/unittest_rbd_mirror --gtest_filter=TestMockImageMap.AddInstancePingPongImageTest --gtest_repeat=10000

@trociny trociny requested a review from dillaman November 2, 2018 17:53
Copy link

@dillaman dillaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dillaman dillaman merged commit c9a44e8 into ceph:master Nov 2, 2018
@trociny trociny deleted the wip-36683 branch November 2, 2018 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants