Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr: Separate diskprediction local plugin from the diskprediction plugin #24925

Merged
merged 3 commits into from
Nov 9, 2018

Conversation

hsiang41
Copy link
Contributor

@hsiang41 hsiang41 commented Nov 5, 2018

Separate diskprediction local plugin from the diskprediction plugin.
Devicehealth invoke device prediction function related on the global
configuration "device_failure_prediction_mode".
Related: PR 24973

Signed-off-by: Rick Chen rick.chen@prophetstor.com

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Separate diskprediction local plugin from the diskprediction plugin.
Devicehealth invoke device prediction function related on the global
 configuration "device_failure_prediction_mode".

Signed-off-by: Rick Chen <rick.chen@prophetstor.com>
@hsiang41
Copy link
Contributor Author

hsiang41 commented Nov 5, 2018

@liewegas

Avoid code exception when the remote plugin not enabled.

Signed-off-by: Rick Chen <rick.chen@prophetstor.com>
@liewegas liewegas changed the title Separate diskprediction local plugin from the diskprediction plugin mgr: Separate diskprediction local plugin from the diskprediction plugin Nov 6, 2018
Copy link
Member

@liewegas liewegas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Failed to import _strptime because the import lockis held by another thread

Signed-off-by: Rick Chen <rick.chen@prophetstor.com>
@liewegas liewegas merged commit 28707a4 into ceph:master Nov 9, 2018
liewegas added a commit that referenced this pull request Nov 9, 2018
* refs/pull/24925/head:
	Avoid import _strptime failed
	Avoid exception if remote plugin not enabled
	Separate diskprediction local plugin from the diskprediction plugin

Reviewed-by: Sage Weil <sage@redhat.com>
@hsiang41 hsiang41 deleted the mgr/device_health branch December 13, 2018 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants