Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: Fix duplicate tasks #24930

Merged
merged 1 commit into from
Nov 8, 2018
Merged

Conversation

tspmelo
Copy link
Contributor

@tspmelo tspmelo commented Nov 5, 2018

In certain situations a new task is already in the current summary before we
manually push it to the running task list.
Since we were not checking that, at the end of the operation we would have 2
entries for the same task and that would be displayed in the UI.

Signed-off-by: Tiago Melo tmelo@suse.com

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

In certain situations a new task is already in the current summary before we
manually push it to the running task list.
Since we were not checking that, at the end of the operation we would have 2
entries for the same task and that would be displayed in the UI.

Signed-off-by: Tiago Melo <tmelo@suse.com>
@tspmelo
Copy link
Contributor Author

tspmelo commented Nov 7, 2018

jenkins retest this please

Copy link

@Devp00l Devp00l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@LenzGr LenzGr merged commit b0ae24b into ceph:master Nov 8, 2018
@tspmelo tspmelo deleted the wip-multiple-actions branch November 8, 2018 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants