mgr/dashboard: Improve CRUSH map viewer

[votdev]

Display the OSD state using a label.

Signed-off-by: Volker Theile vtheile@suse.com

• References tracker ticket
• Updates documentation if necessary
• Includes tests for new functionality or reproducer for bug

[LenzGr]

I tested these improvement on my local development environment.
Before:

After:

LGTM, thank you!

[LenzGr]

Contrary to the OSD table, the OSD status does not seem to dynamically change until I refresh the page. Not a regression as far as I can tell, but I wonder if this is feasible at all?

[votdev]

Contrary to the OSD table, the OSD status does not seem to dynamically change until I refresh the page. Not a regression as far as I can tell, but I wonder if this is feasible at all?

Hmm, this is correct because the crush map viewer does not update the displayed data permanently. It is requested only once when it is displayed.

[Devp00l]

LGTM 👍

[votdev]

jenkins retest this please

[LenzGr]

make check failed:

ERROR: /home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/crushmap/crushmap.component.ts[52, 9]: Identifier 'value' is never reassigned; use 'const' instead of 'let'.
ERROR: /home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/crushmap/crushmap.component.ts[53, 9]: Identifier 'status' is never reassigned; use 'const' instead of 'let'.

[votdev]

make check failed:

ERROR: /home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/crushmap/crushmap.component.ts[52, 9]: Identifier 'value' is never reassigned; use 'const' instead of 'let'.
ERROR: /home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/crushmap/crushmap.component.ts[53, 9]: Identifier 'status' is never reassigned; use 'const' instead of 'let'.

This is strange, i already fixed that... But wait, maybe i didn't push the changes... argghh