mgr/dashboard: fix for 'Cluster >> Hosts' page #24974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfonsomthd
requested review from
tspmelo,
votdev,
ricardoasmarques,
Devp00l and
epuertat
Devp00l
reviewed
Nov 8, 2018
src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/hosts/hosts.component.ts
Outdated
Show resolved
Hide resolved
tspmelo
approved these changes
Nov 8, 2018
- Added permission mapping for 'tcmu-runner' service type. - Avoid error caused by unmapped services' types: The hosts list should be visible even with not mapped services' types, as this mapping only decides whether the service being displayed has a link or not. Fixes: https://tracker.ceph.com/issues/36712 Signed-off-by: Alfonso Martínez <almartin@redhat.com>
alfonsomthd
force-pushed
the
36712-cluser-hosts-fix
branch
from
ea63e3a
to
a5a2da7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hosts list should be visible even with not mapped services' types,
as this mapping only decides whether the service being displayed has a link or not.
Fixes: https://tracker.ceph.com/issues/36712
Signed-off-by: Alfonso Martínez almartin@redhat.com