Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: use 'proxy' cache mode in "Removing a Writeback Cache" procedure #24995

Merged
merged 1 commit into from
Nov 8, 2018

Conversation

trociny
Copy link
Contributor

@trociny trociny commented Nov 8, 2018

The 'forward' mode is flawed as it allows the reordering of requests.

Signed-off-by: Mykola Golub mgolub@suse.com

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

The 'forward' mode is flawed as it allows the reordering of requests.

Signed-off-by: Mykola Golub <mgolub@suse.com>
Copy link
Contributor

@LenzGr LenzGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@liewegas liewegas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@liewegas liewegas merged commit ab880ee into ceph:master Nov 8, 2018
liewegas added a commit that referenced this pull request Nov 8, 2018
* refs/pull/24995/head:
	doc: use 'proxy' cache mode in "Removing a Writeback Cache" procedure

Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Sage Weil <sage@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants