New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: tests: librados api aio tests race condition #25027

Merged
merged 2 commits into from Nov 26, 2018

Conversation

@smithfarm
Copy link
Contributor

smithfarm commented Nov 10, 2018

jdurgin added some commits Oct 23, 2018

test/librados/aio: wait for all completions properly
Using global semaphores was error-prone and unnecessary. Unbalanced
usage resulted in a race like:

aio_write object foo -> dropped on full OSD
aio_read object foo -> -ENOENT

The intent of the test was to wait for the write to complete, so
do that explicitly for each aio test and remove the semaphores.

Fixes: http://tracker.ceph.com/issues/24587
Signed-off-by: Josh Durgin <jdurgin@redhat.com>
(cherry picked from commit 75a776c)
test/librados/aio: remove unused callbacks
That callbacks are called is covered by many other tests.
These particular m_safe and m_complete fields were unused.

Signed-off-by: Josh Durgin <jdurgin@redhat.com>
(cherry picked from commit b148a23)

@smithfarm smithfarm self-assigned this Nov 10, 2018

@smithfarm smithfarm added this to the mimic milestone Nov 10, 2018

@smithfarm smithfarm changed the title mimic: librados api aio tests race condition mimic: tests: librados api aio tests race condition Nov 10, 2018

@smithfarm smithfarm added the tests label Nov 10, 2018

@smithfarm smithfarm requested review from liewegas , tchaikov , neha-ojha and jdurgin Nov 10, 2018

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Nov 16, 2018

@yuriw yuriw merged commit a56f483 into ceph:mimic Nov 26, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-36647-mimic branch Nov 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment