mimic: tests: librados api aio tests race condition #25027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using global semaphores was error-prone and unnecessary. Unbalanced usage resulted in a race like: aio_write object foo -> dropped on full OSD aio_read object foo -> -ENOENT The intent of the test was to wait for the write to complete, so do that explicitly for each aio test and remove the semaphores. Fixes: http://tracker.ceph.com/issues/24587 Signed-off-by: Josh Durgin <jdurgin@redhat.com> (cherry picked from commit 75a776c)
That callbacks are called is covered by many other tests. These particular m_safe and m_complete fields were unused. Signed-off-by: Josh Durgin <jdurgin@redhat.com> (cherry picked from commit b148a23)
smithfarm
changed the title
tchaikov
approved these changes
Nov 10, 2018
jdurgin
approved these changes
Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/36647