-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Improve OpenStack integration and multitenancy docs for radosgw #25056
Conversation
db0d156
to
af2cac9
Compare
jenkins render docs |
Doc render available at http://docs.ceph.com/ceph-prs/25056/ |
af2cac9
to
d0c71b0
Compare
jenkins render docs |
Doc render available at http://docs.ceph.com/ceph-prs/25056/ |
bc18e6a
to
ba1a498
Compare
jenkins render docs |
Doc render available at http://docs.ceph.com/ceph-prs/25056/ |
ba1a498
to
ef1f6ca
Compare
jenkins render docs |
Doc render available at http://docs.ceph.com/ceph-prs/25056/ |
ac14f13
to
e159622
Compare
c0a2061
to
bdfe172
Compare
jenkins render docs |
Doc render available at http://docs.ceph.com/ceph-prs/25056/ |
@fghaas this is a wonderful contribution, thank you |
@mattbenjamin Thanks for the kind words! If you happen to have answers for my questions in http://lists.ceph.com/pipermail/ceph-users-ceph.com/2018-November/031419.html, or know someone who does, I'd be very grateful. Then I'd be able to wrap this up and drop the WIP prefix, so that this is good for final review and merging. |
3a3b22d
to
b608d65
Compare
jenkins render docs |
Doc render available at http://docs.ceph.com/ceph-prs/25056/ |
1ac6992
to
3cbd09b
Compare
Does anyone know why we have to specifically coax Jenkins into a publicly consumable doc render, when there's already a docs build check that runs through the whole build? |
jenkins render docs |
That's actually a good question @fghaas - I wonder if this is something for the ongoing docubetter effort? @neha-ojha - any thoughts on that? |
Doc render available at http://docs.ceph.com/ceph-prs/25056/ |
afaik, to save server space and reduce garbage collection, we don't render docs automatically for all prs , render docs is more of a utility to see how the output would like for those creating docs prs esp when using more rst features |
[removed (was posted unintentionally)] |
Sorry, fat-fingered the close button there. :( |
Doc render available at http://docs.ceph.com/ceph-prs/25056/ |
3cbd09b
to
f875d14
Compare
Now that the U.S. holiday weekend is over, I would hugely appreciate if someone with approval karma could give this a final review. @mattbenjamin perhaps? |
@rzarzynski could you please help with review? |
@mdw-at-linuxbox can you please contribute a review by, say, 12/10/2018? |
Taking the liberty to poke this again. If everyone's in agreement that this is good to merge then I'd love to see it merged before I tackle my next doc patch (on rbdmirror) — as I would have real trouble juggling two or more pending patches, due to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fghaas see my comment there, otherwise fine.
doc/radosgw/config-ref.rst
Outdated
|
||
If set to ``false`` (the default), then the Swift API | ||
will listen on a URL formed like | ||
``http://host:port/<rgw_swift_url_prefix/v1``, and the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fghaas note that the rgw_swift_url_prefix
here and on other places is missing >
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yehudasa Thanks! Well spotted. Fixed, amended, and force-pushed. Since this has been in the making for a while now, should I be rebasing on current master?
Add explanatory information on: * "rgw swift account in url" (including the Swift account in the Swift API url and Keystone endpoint) * "rgw swift versioning enabled" (enabling Swift object versioning) * "rgw s3 auth use keystone" (enabling S3 authentication against Keystone) * "rgw keystone implicit tenants" (multi-tenancy via Keystone, including its implications for the Swift and S3 APIs) Fixes: http://tracker.ceph.com/issues/36765 Signed-off-by: Florian Haas <florian@citynetwork.eu>
f875d14
to
d730820
Compare
Not sure if this has anything to do with my patch? |
@fghaas |
Thanks for merging, @yehudasa! |
Add explanatory information on:
rgw swift account in url
(including the Swift account in the Swift API url and Keystone endpoint)rgw swift versioning enabled
(enabling Swift object versioning)rgw s3 auth use keystone
(enabling S3 authentication against Keystone)rgw keystone implicit tenants
(multi-tenancy via Keystone, including its implications for the Swift and S3 APIs)