build/ops: rpm: RHEL 8 needs Python 3 build #25223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathan Cutler <ncutler@suse.com>
smithfarm
requested review from
tchaikov,
ktdreyer,
dillaman,
b-ranto,
djgalloway,
dmick and
badone
b-ranto
approved these changes
Nov 22, 2018
badone
approved these changes
Nov 22, 2018
tchaikov
approved these changes
Nov 23, 2018
| @@ -57,7 +57,7 @@ | |||
| %endif | |||
| %endif | |||
| %bcond_with seastar | |||
| %if 0%{?fedora} >= 29 || 0%{?suse_version} >= 1500 | |||
| %if 0%{?fedora} >= 29 || 0%{?suse_version} >= 1500 || 0%{?rhel} >= 8 | |||
There was a problem hiding this comment.
cool! didn't realize that RHEL8 is using python3 as the default python. see https://developers.redhat.com/blog/2018/11/14/python-in-rhel-8/
spec macro writers really need to try harder to make things confusing |
|
@dmick Wins prize for "least aptly named RPM macro" (pun - get it, get it?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nathan Cutler ncutler@suse.com