mgr: fix 'ceph fs status' output divided by zero error

[gmayyyha]

Error EINVAL: Traceback (most recent call last):
  File "/home/tiger/ceph/src/pybind/mgr/status/module.py", line 314, in handle_command
    return self.handle_fs_status(cmd)
  File "/home/tiger/ceph/src/pybind/mgr/status/module.py", line 174, in handle_fs_status
    ) + "/s"
  File "/home/tiger/ceph/src/pybind/mgr/status/module.py", line 113, in get_rate
    return (data[-1][1] - data[-2][1]) / float(data[-1][0] - data[-2][0])
ZeroDivisionError: float division by zero

• References tracker ticket
• Updates documentation if necessary
• Includes tests for new functionality or reproducer for bug

[sebastian-philipp]

EAFP. what about just catching ZeroDivisionError?

[sebastian-philipp]

Btw, these are also broken then: dashboard.services.ceph_service.differentiate and diskprediction_cloud.common.clusterdata.differentiate and status.module.Module#get_rate .

[LenzGr]

Btw, these are also broken then [...]

@gmayyyha , @sebastian-philipp - would it make sense to fix these in this PR as well?

[gmayyyha]

EAFP. what about just catching ZeroDivisionError?

@sebastian-philipp mds subtree migration.

[gmayyyha]

Btw, these are also broken then [...]

@gmayyyha , @sebastian-philipp - would it make sense to fix these in this PR as well?

@LenzGr @sebastian-philipp define a common function to solve all of these?

dismiss

[gmayyyha]

@sebastian-philipp done all.

[sebastian-philipp]

needs rebase. diskprediction was renamed to diskprediction_cloud.

[sebastian-philipp]

Would be nice if you could merge both copies of differentiate into a new common file: src/pybind/mgr/mgr_util.py. Let's fight code duplication inside mgr modules.

[gmayyyha]

done.

[sebastian-philipp]

Relates to #25360

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you are a maintainer or core committer, please follow-up on this issue to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

[sebastian-philipp]

replaced with #26270