mimic: core: os/bluestore_tool: fix bluefs expand #25348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smithfarm
suggested changes
Dec 1, 2018
There was a problem hiding this comment.
@ifed01 In the tracker you wrote a nice explanation for why these commits cannot be cherry-picked from master: "The mimic fix is completely different from Nautilus one as we don't backport main device expansion feature."
Could you please add this sentence to both commit messages, so the explanation is readily available to anyone perusing the git history? Thanks.
ifed01
force-pushed
the
wip-ifed-fix-expand-mimic
branch
from
abbca4c
to
b0d6efb
Compare
|
@smithfarm - updated |
…dable Fixes: https://tracker.ceph.com/issues/37494 This commit is specific for pre-Nautilius releases (mimic & luminous) as we don't backport main device expansion feature. Which makes this mimic/luminous commit completely different from nautilus one. Signed-off-by: Igor Fedotov <ifedotov@suse.com>
This commit is specific for pre-Nautilius releases (mimic & luminous) as we don't backport main device expansion feature. Which makes this mimic/luminous commit completely different from nautilus one. Signed-off-by: Igor Fedotov <ifedotov@suse.com>
ifed01
force-pushed
the
wip-ifed-fix-expand-mimic
branch
from
b0d6efb
to
c098f5f
Compare
smithfarm
changed the title
smithfarm
approved these changes
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tracker.ceph.com/issues/37494
Signed-off-by: Igor Fedotov ifedotov@suse.com