mds: setup readonly mode for PurgeQueue #25621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
batrick
commented
Dec 19, 2018
batrick
commented
batrick
force-pushed
the
i37543
branch
2 times, most recently
from
b94b504
to
3879aaa
Compare
ukernel
reviewed
Dec 24, 2018
src/mds/PurgeQueue.cc
Outdated
| dout(10) << "cannot create: PurgeQueue is readonly" << dendl; | ||
| if (fin) | ||
| fin->complete(-EROFS); | ||
| return; |
There was a problem hiding this comment.
this does not make sense for creating new prugequeue. Instead, we should check error in finish context of writing journal head. (at later this function)
There was a problem hiding this comment.
thanks, please have another look
Otherwise it leaks. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
These could race with the asynchronous workings of the PQ. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
This is a cheap refactor. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
If the PQ faces an error, it should go read-only along with the MDS rank. Fixes: http://tracker.ceph.com/issues/37543 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
ukernel
approved these changes
Jan 3, 2019
batrick
added a commit
to batrick/ceph
that referenced
this pull request
Jan 8, 2019
* refs/pull/25621/head: mds: allow boot on read-only mds: setup readonly mode for PurgeQueue mds: return string_view for type str mds: add missing locks for PurgeQueue methods mds: delete on_error context on des Reviewed-by: Zheng Yan <zyan@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.