Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: pybind/mgr: drop unnecessary iterkeys usage to make py-3 compatible #25759

Merged
merged 1 commit into from Jan 25, 2019

Conversation

pdvian
Copy link

@pdvian pdvian commented Jan 3, 2019

Fixes: http://tracker.ceph.com/issues/37581
Signed-off-by: Mykola Golub <mgolub@suse.com>
(cherry picked from commit 7d1c7ec)

Conflicts:
	src/pybind/mgr/devicehealth/module.py : Removed as not available in mimic
@pdvian
Copy link
Author

pdvian commented Jan 3, 2019

@trociny could not backport devicehealth/module.py changes as it is not available in mimic. Need review.

@tchaikov tchaikov added this to the mimic milestone Jan 3, 2019
Copy link
Contributor

@trociny trociny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuriw
Copy link
Contributor

yuriw commented Jan 16, 2019

@yuriw yuriw merged commit 5de2aa1 into ceph:mimic Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants