Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: rgw: handle S3 version 2 pre-signed urls with meta-data #25901

Merged
merged 2 commits into from Feb 25, 2019

Commits on Jan 10, 2019

  1. rgw: distinguish parse_v4_credentials

    The caller and callees of this method are v4-specific, and their
    names contain a v4 infix.
    
    Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
    (cherry picked from commit aa8c686)
    
    Conflicts:
    	src/rgw/rgw_auth_s3.cc
    	src/rgw/rgw_auth_s3.h
    	src/rgw/rgw_rest_s3.cc
    	   - Included v4 infix in 'parse_credentials()' and removed
    	    "session_token" param from definition, declaration and call
    	    of 'parse_v4_credentials()'.
    mattbenjamin authored and ashishkumsingh committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    dd7d957 View commit details
    Browse the repository at this point in the history
  2. rgw: handle S3 version 2 pre-signed urls with meta-data

    Add CanonicalizedAmzHeaders to the v2 signing document, as required
    in https://docs.aws.amazon.com/AmazonS3/latest/dev/RESTAuthentication.html
    
    Also lift qs metadata into x_meta_map in RGWPutObj_ObjStore_S3::get_parms(),
    so they are applied to the stored object.
    
    Fixes: https://tracker.ceph.com/issues/23470
    Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
    (cherry picked from commit 3b0480e)
    
    Conflicts:
    	src/rgw/rgw_rest_client.cc
    	   - Used 'method()' instead of 'method.c_str()' and
    	     'new_url.c_str()' instead of 'url.c_str()'
    mattbenjamin authored and ashishkumsingh committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    966c6dc View commit details
    Browse the repository at this point in the history