mds: convert const char ptr to string_view #25921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batrick
force-pushed
the
mds-string_view
branch
8 times, most recently
from
954ee6a
to
f1679cf
Compare
Also, don't store pointers to strings outside. The interface was written to optimize for string literals but this is structurally unsafe programming. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
batrick
force-pushed
the
mds-string_view
branch
2 times, most recently
from
45ae2c5
to
d284ca0
Compare
Trivial refactor. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
batrick
force-pushed
the
mds-string_view
branch
from
d284ca0
to
6dfa87f
Compare
batrick
added a commit
that referenced
this pull request
Jan 14, 2019
* refs/pull/25921/head: mds: convert const char ptr to string_view common/TrackedOp: use string_view interface Reviewed-by: Sage Weil <sage@redhat.com>
This was referenced Jul 1, 2019
tchaikov
reviewed
Jul 9, 2019
| @@ -234,35 +234,26 @@ class TrackedOp : public boost::intrusive::list_base_hook<> { | |||
|
|
|||
| struct Event { | |||
| utime_t stamp; | |||
| string str; | |||
| const char *cstr = nullptr; | |||
| std::string str; | |||
There was a problem hiding this comment.
this forces us to create a std::string from string_view. IMHO, it practically defeats the purpose of using string_view. i'd use std::variant<> for holding the string_view or std::string.
There was a problem hiding this comment.
The std::string_view may not refer to static memory? In several places, an Event is created with s referring to a temporary string.
There was a problem hiding this comment.
i think we can differentiate that case at the caller site, can't we? and instead move the temporary string or copy it to the one in Event.
There was a problem hiding this comment.
I agree with you. See my comment here: #28849 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.