qa/workunits/cephtool/test.sh: fix thrash (ultimate) #2594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep the osd trash test to ensure it is a valid command but make it a noop by giving it a zero argument (meaning thrash 0 OSD maps). Remove the loops that were added after the command in an attempt to wait for the cluster to recover and not pollute the rest of the tests. Actual testing of osd thrash would require a dedicated cluster because it the side effects are random and it is unnecessarily difficult to ensure they are finished. http://tracker.ceph.com/issues/9620 Fixes: #9620 Signed-off-by: Loic Dachary <loic-201408@dachary.org>
liewegas
added a commit
that referenced
this pull request
Sep 29, 2014
qa/workunits/cephtool/test.sh: fix thrash (ultimate) Reviewed-by: Sage Weil <sage@redhat.com>
|
yay, so much better |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep the osd trash test to ensure it is a valid command but make it a
noop by giving it a zero argument (meaning thrash 0 OSD maps).
Remove the loops that were added after the command in an attempt to wait
for the cluster to recover and not pollute the rest of the tests. Actual
testing of osd thrash would require a dedicated cluster because it the
side effects are random and it is unnecessarily difficult to ensure they
are finished.
http://tracker.ceph.com/issues/9620 Fixes: #9620
Signed-off-by: Loic Dachary loic-201408@dachary.org