ceph-volume fix TypeError on dmcrypt when using Python3 #26034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 18, 2019 12:50
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Signed-off-by: Alfredo Deza <adeza@redhat.com>
marcan
reviewed
Jan 19, 2019
| @@ -23,7 +23,7 @@ def create_dmcrypt_key(): | |||
| ) | |||
| # The size of the key is defined in bits, so we must transform that | |||
| # value to bytes (dividing by 8) because we read in bytes, not bits | |||
| random_string = os.urandom(dmcrypt_key_size / 8) | |||
| random_string = os.urandom(int(dmcrypt_key_size / 8)) | |||
There was a problem hiding this comment.
I think it's more Pythonic to use // (truncating division) instead of casting to an int later. That works in 2.7 too.
There was a problem hiding this comment.
Casting to an int here prevents someone defining a float in dmcrypt_key_size, in which case, the float would be preserved. I would agree that just using // would be preferable otherwise.
andrewschoen
approved these changes
Jan 23, 2019
|
jenkins test ceph-volume lvm all |
This was referenced Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/37963