Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/zabbix: drop "total_objects" field #26052

Merged
merged 1 commit into from Jan 21, 2019
Merged

Conversation

tchaikov
Copy link
Contributor

This field was removed from df output a while back in
342f309

Signed-off-by: Kefu Chai kchai@redhat.com

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

This field was removed from df output a while back in
342f309

Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov
Copy link
Contributor Author

this change should fix the failure of http://pulpito.ceph.com/kchai-2019-01-21_09:40:59-rados-wip-kefu2-testing-2019-01-21-1515-distro-basic-mira/3489233/

2019-01-21T10:22:44.372 INFO:teuthology.orchestra.run.mira081.stderr:2019-01-21 10:22:44.365 7f9338ff9700  1 -- v2:172.21.7.124:42660/1154950056 <== mgr.12174 v2:172.21.7.124:6800/29533 1 ==
== command_reply(tid 0: -1 Test failed: Remote method threw exception: Traceback (most recent call last):
2019-01-21T10:22:44.372 INFO:teuthology.orchestra.run.mira081.stderr:  File "/usr/lib/ceph/mgr/zabbix/module.py", line 350, in self_test
2019-01-21T10:22:44.372 INFO:teuthology.orchestra.run.mira081.stderr:    data = self.get_data()
2019-01-21T10:22:44.372 INFO:teuthology.orchestra.run.mira081.stderr:  File "/usr/lib/ceph/mgr/zabbix/module.py", line 174, in get_data
2019-01-21T10:22:44.372 INFO:teuthology.orchestra.run.mira081.stderr:    data['total_objects'] = df['stats']['total_objects']
2019-01-21T10:22:44.372 INFO:teuthology.orchestra.run.mira081.stderr:KeyError: ('total_objects',)

at http://pulpito.ceph.com/kchai-2019-01-21_09:40:59-rados-wip-kefu2-testing-2019-01-21-1515-distro-basic-mira/3489233/.

see also #26046

@tchaikov
Copy link
Contributor Author

@tchaikov tchaikov merged commit e2ff665 into ceph:master Jan 21, 2019
@tchaikov tchaikov deleted the wip-37976 branch January 21, 2019 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants