Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mimic: mds: purge queue recovery hangs during boot if PQ journal is damaged #26055

Merged
merged 4 commits into from Feb 5, 2019
Merged

mimic: mds: purge queue recovery hangs during boot if PQ journal is damaged #26055

merged 4 commits into from Feb 5, 2019

Conversation

smithfarm
Copy link
Contributor

@smithfarm smithfarm self-assigned this Jan 21, 2019
@smithfarm smithfarm added this to the mimic milestone Jan 21, 2019
@smithfarm smithfarm added bug-fix core cephfs Ceph File System and removed core labels Jan 21, 2019
batrick
batrick previously requested changes Jan 30, 2019
View reviewed changes
Copy link
Member

@batrick batrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase

@batrick @smithfarm
mds: delete on_error context on des
6feccc3 
Otherwise it leaks.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 3327982)
@batrick @smithfarm
mds: add missing locks for PurgeQueue methods
15848cc 
These could race with the asynchronous workings of the PQ.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit c7350ac)

Conflicts:
	src/mds/PurgeQueue.cc
- use Mutex::Locker instead of std::lock_guard
- no "ceph_assert" in mimic
@batrick @smithfarm
mds: setup readonly mode for PurgeQueue
fd2ef7b 
If the PQ faces an error, it should go read-only along with the MDS rank.

Fixes: http://tracker.ceph.com/issues/37543
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 4cccc4d)

Conflicts:
	src/mds/PurgeQueue.cc
- Mutex::Locker instead of std::lock_guard
- no ceph_assert in mimic
@batrick @smithfarm
mds: allow boot on read-only
715e2eb 
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit c7ce967)

Conflicts:
	src/mds/MDSRank.cc
- no ceph_assert in mimic
@smithfarm
Copy link
Contributor Author

@batrick Rebase complete.

@yuriw
Copy link
Contributor

yuriw commented Jan 31, 2019

wip-yuri3-testing-2019-01-31-2315-mimic

@yuriw yuriw merged commit bc3aeff into ceph:mimic Feb 5, 2019
@smithfarm smithfarm deleted the wip-37898-mimic branch February 6, 2019 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vshankar vshankar vshankar approved these changes

@batrick batrick batrick left review comments

Assignees

@smithfarm smithfarm

Labels
bug-fix cephfs Ceph File System mimic-batch-1 needs-qa wip-yuri3-testing
Projects
None yet
Milestone
mimic
4 participants
@smithfarm @yuriw @vshankar @batrick