mgr/dashboard: Add description to menu items on mobile navigation #26198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-se
approved these changes
Jan 30, 2019
votdev
approved these changes
Jan 31, 2019
|
Should it look like this? |
I would prefer the proposed look over what we currently have, but that might be a different PR. |
Yes, thank you for adding the screenshot ;) |
tspmelo
reviewed
Feb 4, 2019
.../mgr/dashboard/frontend/src/app/core/navigation/administration/administration.component.html
Outdated
Show resolved
Hide resolved
.../mgr/dashboard/frontend/src/app/core/navigation/dashboard-help/dashboard-help.component.html
Outdated
Show resolved
Hide resolved
I was looking for something like this. Thanks for the hint, will change it :-) |
added 2 commits
February 5, 2019 13:47
Adds the title of the icons as description right next to it if the resolution of the browser is below 768px. Adds a couple of scss variable which define the different breakpoints of bootstrap. Those variables should be used in media query expressions. Fixes: https://tracker.ceph.com/issues/37789 Signed-off-by: Sebastian Krah <skrah@suse.com>
Uses the newly created scss breakpoint variables for every media query that was hardcoded so far. Signed-off-by: Sebastian Krah <skrah@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the title of the icons as description right next to it if the resolution
of the browser is below 768px.
In addtition, I've added some sccs variables that should be used when working with media queries. Those variables define the bootstrap breakpoints.