mimic: common: fix missing include boost/noncopyable.hpp #26277
Conversation
Clang complains:
```
In file included from /home/jenkins/workspace/ceph-master/src/osd/ReplicatedBackend.cc:15:
In file included from /home/jenkins/workspace/ceph-master/src/osd/ReplicatedBackend.h:18:
In file included from /home/jenkins/workspace/ceph-master/src/osd/PGBackend.h:27:
In file included from /home/jenkins/workspace/ceph-master/src/osd/PGTransaction.h:25:
/home/jenkins/workspace/ceph-master/src/common/inline_variant.h:88:64: error: expected class name
struct generic_visitor : boost::static_visitor<Result>, boost::noncopyable
^
1 error generated.
gmake[2]: *** [src/osd/CMakeFiles/osd.dir/build.make:141: src/osd/CMakeFiles/osd.dir/ReplicatedBackend.cc.o] Error 1
gmake[2]: *** Waiting for unfinished jobs....
```
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
(cherry picked from commit 0654099)
|
@wjwithagen @tchaikov Before opening a PR with a cherry-pick to a stable branch, would it be possible to first:
Beyond that the backporting team will take care of it. If you really want to do the cherry-pick yourself, the next steps would be:
|
smithfarm
changed the title
|
@smithfarm |
@wjwithagen Absolutely! In that case don't fill out "Pull Request ID" field, but just specify the SHA1 of the commit in the tracker description. E.g. description might be: "Commit 343asdfkl34321409893jfadfsd fixes issue XYZ. Please backport just this one commit to mimic." (and fill out "Backport: mimic" and "Status: Pending Backport" - that's all, you're done) |
|
Right, but in this case the whole PR turns out to be only 1 commit to several files. |
|
@wjwithagen That's a special case. . . Can you still open the tracker and specify in the description exactly what you need? If you do it now, I'll create the backport issue for you and you can then do the manual partial cherry-pick yourself. OK? |
|
In the commit description you can write: "This is a manual partial cherry-pick of [SHA1]" |
|
@wjwithagen in future, i'd suggest use one's own repo for topic branches instead of using ceph/ceph for hosting them. |
|
@tchaikov |
|
@wjwithagen i suggest push your changes to your own repo, namely https://github.com/wjwithagen/ceph/ , and create PR from there instead of pushing to https://github.com/ceph/ceph/ . |
|
@tchaikov |
http://tracker.ceph.com/issues/38179