ceph.spec.in: Don't use noarch for mgr module subpackages, fix /usr/lib64/ceph/mgr dir ownership #26398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though ceph-mgr modules are notionally non-architecture-specific, the files themselves are installed to an architecture-specific path (/usr/lib64/ceph/mgr/....), which causes the build to fail on SUSE distros with a huge long list of errors like: ceph-mgr-diskprediction-cloud.noarch: E: suse-filelist-forbidden-noarch (Badness: 10000) /usr/lib64/ceph/mgr/diskprediction_cloud is not allowed in a noarch package [...] (none): E: badness 1120287 exceeds threshold 1000, aborting. Signed-off-by: Tim Serong <tserong@suse.com>
Without this, no package actually owns the /usr/lib64/ceph/mgr directory so the build fails with "directories not owned by a package" errors for ceph-mgr, ceph-mgr-diskprediction-local, ceph-mgr-diskprediction-cloud and ceph-mgr-rook. Signed-off-by: Tim Serong <tserong@suse.com>
3 tasks
hmm, we need to fix it by moving them to |
tchaikov
approved these changes
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of small kinks resulting from #25977:
ceph-mgr-diskprediction-cloud.noarch: E: suse-filelist-forbidden-noarch (Badness: 10000) /usr/lib64/ceph/mgr/diskprediction_cloud is not allowed in a noarch package
[...]
(none): E: badness 1120287 exceeds threshold 1000, aborting.