messages: provide an explicit COMPAT_VERSION in MMDSBeacon #2640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We weren't setting an explicit compat version and so the Message was setting it to the head version, breaking communication with older daemons. Fixes: #9657 Signed-off-by: Greg Farnum <greg@inktank.com>
|
@jcsp for future reference, this is a thing when modifying older messages. Sorry I didn't notice in review. :( |
liewegas
added a commit
that referenced
this pull request
Oct 4, 2014
messages: provide an explicit COMPAT_VERSION in MMDSBeacon Reviewed-by: Sage Weil <sage@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't setting an explicit compat version and so the Message
was setting it to the head version, breaking communication with
older daemons.
Fixes: #9657
This is only compile tested.