Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mimic: osd: src/osd/OSDMap.h: 1065: FAILED assert(__null != pool) #26594

Closed
wants to merge 1 commit into from
Closed

mimic: osd: src/osd/OSDMap.h: 1065: FAILED assert(__null != pool) #26594

wants to merge 1 commit into from

Conversation

smithfarm
Copy link
Contributor

@smithfarm smithfarm self-assigned this Feb 22, 2019
@smithfarm smithfarm added this to the mimic milestone Feb 22, 2019
@smithfarm smithfarm changed the title mimic: src/osd/OSDMap.h: 1065: FAILED assert(__null != pool) mimic: osd: src/osd/OSDMap.h: 1065: FAILED assert(__null != pool) Feb 22, 2019
@smithfarm
Copy link
Contributor Author

Build failure:

/home/jenkins-build/build/workspace/ceph-pull-requests/src/osd/OSD.cc: In member function 'bool OSD::project_pg_history(spg_t, pg_history_t&, epoch_t, const OSDMap&, const std::vector<int>&, int, const std::vector<int>&, int)':
/home/jenkins-build/build/workspace/ceph-pull-requests/src/osd/OSD.cc:4218:51: error: base operand of '->' has non-pointer type 'const OSDMap'
            << " from " << from << " to " << endmap->get_epoch()
                                                   ^~
/home/jenkins-build/build/workspace/ceph-pull-requests/src/osd/OSD.cc:4223:18: error: base operand of '->' has non-pointer type 'const OSDMap'
   for (e = endmap->get_epoch();
                  ^~
/home/jenkins-build/build/workspace/ceph-pull-requests/src/osd/OSD.cc:4258:15: error: base operand of '->' has non-pointer type 'const OSDMap'
         endmap->get_pg_num(pgid.pool()),
               ^~
/home/jenkins-build/build/workspace/ceph-pull-requests/src/osd/OSD.cc: In member function 'void OSD::handle_pg_query_nopg(const MQuery&)':
/home/jenkins-build/build/workspace/ceph-pull-requests/src/osd/OSD.cc:8612:43: error: no matching function for call to 'OSD::project_pg_history(spg_t&, pg_history_t&, const epoch_t&, OSDMapRef&, std::vector<int>&, int&, std::vector<int>&, int&)'
     up, up_primary, acting, acting_primary);
                                           ^
/home/jenkins-build/build/workspace/ceph-pull-requests/src/osd/OSD.cc:4210:6: note: candidate: bool OSD::project_pg_history(spg_t, pg_history_t&, epoch_t, const OSDMap&, const std::vector<int>&, int, const std::vector<int>&, int)
 bool OSD::project_pg_history(spg_t pgid, pg_history_t& h, epoch_t from,
      ^~~
/home/jenkins-build/build/workspace/ceph-pull-requests/src/osd/OSD.cc:4210:6: note:   no known conversion for argument 4 from 'OSDMapRef {aka std::shared_ptr<const OSDMap>}' to 'const OSDMap&'
src/osd/CMakeFiles/osd.dir/build.make:62: recipe for target 'src/osd/CMakeFiles/osd.dir/OSD.cc.o' failed
make[3]: *** [src/osd/CMakeFiles/osd.dir/OSD.cc.o] Error 1

@smithfarm smithfarm added the DNM label Feb 22, 2019
@smithfarm
Copy link
Contributor Author

@dzafman Could I trouble you to look at the build failure? It's too non-trivial for my poor brain.

dzafman
dzafman approved these changes Mar 4, 2019
View reviewed changes
Copy link
Contributor

@dzafman dzafman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dzafman
Copy link
Contributor

dzafman commented Apr 25, 2019

retest this please

@liewegas @smithfarm
osd: make project_pg_history handle concurrent osdmap publish
718e696 
The class's osdmap may be updated while we are in our loop.  Pass it in
explicitly instead.

Fixes: http://tracker.ceph.com/issues/26970
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit cfe6ca8)
@smithfarm
Copy link
Contributor Author

build still failing; rebased

@smithfarm smithfarm removed their assignment Jul 23, 2019
@smithfarm
Copy link
Contributor Author

closing because the backport is non-trivial

@smithfarm smithfarm closed this Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liewegas liewegas liewegas approved these changes

@dzafman dzafman dzafman approved these changes

@neha-ojha neha-ojha Awaiting requested review from neha-ojha

Assignees
No one assigned
Labels
bug-fix core DNM
Projects
None yet
Milestone
mimic
3 participants
@smithfarm @dzafman @liewegas