rpm: Fix pyOpenSSL dependency #26617
Merged
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
reviewed
Feb 25, 2019
"fix" is kind of vague in this context. could you explain the rationale in the commit message? for instance
|
Fedora29 does not have pyOpenSSL but it does have python-pyOpenSSL Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
badone
force-pushed
the
wip-fix-pyopenssl-requirement
branch
from
92f8004
to
ff324f4
Compare
|
As it is written, so shall it be. |
tchaikov
approved these changes
Feb 25, 2019
ktdreyer
approved these changes
Feb 25, 2019
liewegas
added a commit
that referenced
this pull request
Feb 25, 2019
* refs/pull/26617/head: rpm: Fix pyOpenSSL dependency Reviewed-by: Kefu Chai <kchai@redhat.com> Reviewed-by: Ken Dreyer <kdreyer@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Brad Hubbard bhubbard@redhat.com
#26402 broke install-deps.sh on Fedora 29. I think the following should work on all platforms. Possibly only need an if else.