Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luminous: qa/workunits/cephtool/test.sh: Use :- to handle TMPDIR="" #26686

Merged
merged 3 commits into from Mar 4, 2019
Merged

luminous: qa/workunits/cephtool/test.sh: Use :- to handle TMPDIR="" #26686

merged 3 commits into from Mar 4, 2019

Conversation

dzafman
Copy link
Contributor

@dzafman dzafman commented Feb 28, 2019

No description provided.

@dzafman
qa/workunits/cephtool/test.sh: Use :- to handle TMPDIR=""
3e328c0 
Only Luminous has seen TMPDIR="" coming into this script.

Signed-off-by: David Zafman <dzafman@redhat.com>
@dzafman
Revert "qa/suites/rados/singleton: more whitelist"
761a9aa 
This reverts commit 77258ed.

Signed-off-by: David Zafman <dzafman@redhat.com>

Conflicts:
	qa/suites/rados/singleton/all/osd-recovery.yaml (trivial)
	qa/suites/rados/singleton/all/thrash-eio.yaml (trivial)
@dzafman
test: Add "slow request" to whitelist for Luminous
8ceb94c 
Redo backport 0e98766

Replaces: 77258ed

Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit 0e98766)

Conflicts:
	qa/suites/rados/singleton/all/osd-recovery.yaml (Use "slow request" for luminous)
	qa/suites/rados/singleton/all/thrash-eio.yaml (Use "slow request" for luminous, keep OBJECT_MISPLACED)
@dzafman dzafman added the tests label Feb 28, 2019
@dzafman dzafman added this to the luminous milestone Feb 28, 2019
tchaikov
tchaikov reviewed Feb 28, 2019
View reviewed changes
qa/workunits/cephtool/test.sh
@@ -49,7 +49,7 @@ function expect_false()
}


TEMP_DIR=$(mktemp -d ${TMPDIR-/tmp}/cephtool.XXX)
TEMP_DIR=$(mktemp -d ${TMPDIR:-/tmp}/cephtool.XXX)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack.

tchaikov
tchaikov approved these changes Feb 28, 2019
View reviewed changes
Copy link
Contributor

@tchaikov tchaikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm aside from the nits against commit message

qa/suites/rados/singleton/all/osd-recovery.yaml Outdated
@@ -22,6 +22,7 @@ tasks:
- \(OBJECT_DEGRADED\)
- \(SLOW_OPS\)
- \(REQUEST_SLOW\)
- slow requests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add a

(cherry picked from commit 0e987665fe480530a0d1664392604713828bfa5c)

line with a Conflicts: section? so we can connect it to the change in master, and explain that this change is adapted to luminous ?

@neha-ojha
Copy link
Member

@yuriw Can we prioritize the testing of this PR? Let's run this PR individually through a rados run and see how many failures still show up on luminous.

@dzafman
Copy link
Contributor Author

dzafman commented Feb 28, 2019

@yuriw OK, I'll do a rados run.

@yuriw yuriw added the core label Feb 28, 2019
@dzafman
Copy link
Contributor Author

dzafman commented Mar 1, 2019

I shouldn't have remove (OBJECT_MISPLACED) from thrash-eio.yaml. Added back.

@dzafman
Copy link
Contributor Author

dzafman commented Mar 1, 2019

http://pulpito.ceph.com/dzafman-2019-02-28_11:54:32-rados-wip-zafman-testing-luminous-distro-basic-smithi/
3650912 DEAD Fixed by #25956

3650790 slow request (correction to wip-test-fix)
3650863 OBJECT_MISPLACED (correction to wip-test-fix)

Infrastructure
3650824
3650833

http://tracker.ceph.com/issues/37866
luminous: mgr/test_localpool.sh fails after multiple tries
3650746
3650916

http://tracker.ceph.com/issues/22137
while scanning a plain scalar in "/tmp/teuth_ansible_failures_o0W6zE", line 1, column 196 found unexpected ':' in "/tmp/teuth_ansible_failures_o0W6zE", line 1, column 202
3650865
3650875
3650905
3650909
3650920

@dzafman dzafman force-pushed the wip-test-fix branch 2 times, most recently from 988332c to 8ceb94c Compare March 2, 2019 05:00
@dzafman
Copy link
Contributor Author

dzafman commented Mar 4, 2019

http://pulpito.ceph.com/dzafman-2019-03-01_09:55:16-rados-wip-zafman-testing-luminous2-distro-basic-smithi/
3654188 while scanning a plain scalar in "/tmp/teuth_ansible_failures_VqT1TJ", line 1, column 196 found unexpected ':' in "/tmp/teuth_ansible_failures_VqT1TJ"
3654193 http://tracker.ceph.com/issues/17257
3654336 mgr/test_localpool.sh
3654343 qa/workunits/rest/test.py
3654356 slow request needed for thrash-eio.yaml (needs "slow requests" -> "slow request")
3654383 qa/workunits/rest/test.py

@neha-ojha neha-ojha merged commit df474b8 into ceph:luminous Mar 4, 2019
@dzafman dzafman deleted the wip-test-fix branch March 4, 2019 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchaikov tchaikov tchaikov approved these changes

@yuriw yuriw yuriw approved these changes

Assignees
No one assigned
Labels
core luminous-batch-1 tests
Projects
None yet
Milestone
luminous
4 participants
@dzafman @neha-ojha @tchaikov @yuriw