mgr/pg_autoscaler: Fix python3 incompatibility #27079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
approved these changes
Mar 21, 2019
sebastian-philipp
approved these changes
Mar 21, 2019
|
Could you please replace |
Fixes: http://tracker.ceph.com/issues/38626 Signed-off-by: Marius Schiffer <marius@mschiffer.de>
MariusSchiffer
force-pushed
the
fix-py3-autoscaler
branch
from
ff0f4f3
to
8da78e0
Compare
MariusSchiffer
changed the title
Oh wow, I did not notice that. Fixed. |
|
retest this please |
1 similar comment
|
retest this please |
liewegas
added a commit
that referenced
this pull request
Mar 25, 2019
* refs/pull/27079/head: mgr/pg_autoscaler: Fix python3 incompatibility Reviewed-by: Kefu Chai <kchai@redhat.com> Reviewed-by: Sebastian Wagner <swagner@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: http://tracker.ceph.com/issues/38626
Signed-off-by: Marius Schiffer marius@mschiffer.de
itervalues and iteritems were replaced with their six correspondents. six is already a dependency, so this should be no problem.
Alternatively, we could replace itervalues, iterkeys with .values() and .keys().
This would always return a list on python2 (negligible performance impact, only if there are a lot of pools or roots) but in my opinion increase readability.