Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luminous: rgw: GetBucketCORS API returns Not Found error code when CORS configuration does not exist #27123

Merged
merged 2 commits into from Jun 26, 2019
Merged

luminous: rgw: GetBucketCORS API returns Not Found error code when CORS configuration does not exist #27123

merged 2 commits into from Jun 26, 2019

Conversation

smithfarm
Copy link
Contributor

yuliyang and others added 2 commits March 22, 2019 14:34
@smithfarm
rgw: cors rules num limit
1c776f5 
According to AWS S3, an cors rules can
have up to 100 rules.

Signed-off-by: yuliyang <yuliyang@cmss.chinamobile.com>
(cherry picked from commit c97ee93)

Conflicts:
	src/common/options.cc
- luminous lacks some options that are present in master
@ashitakasam @smithfarm
rgw: the error code returned by rgw is different from amz s3 when
f950a7a 
getting cors from the bucket without cors configuration

Fixes: http://tracker.ceph.com/issues/26964

Signed-off-by: ashitakasam <694240887@qq.com>
(cherry picked from commit 009a67f)

Conflicts:
	src/rgw/rgw_common.cc
- luminous has no ERR_NO_ROLE_FOUND
	src/rgw/rgw_op.cc
- mimic uses dout(2) instead of ldpp_dout(this, 2)
@smithfarm smithfarm self-assigned this Mar 22, 2019
@smithfarm smithfarm added this to the luminous milestone Mar 22, 2019
@smithfarm smithfarm requested a review from cbodley March 22, 2019 13:37
@smithfarm
Copy link
Contributor Author

@cbodley Cherry-picking c97ee93 first seemed to be the right thing to do here, but perhaps it's not necessary/desirable?

@smithfarm
Copy link
Contributor Author

@vumrao

@vumrao
Copy link
Contributor

vumrao commented Mar 22, 2019

thanks @smithfarm

@smithfarm smithfarm changed the title luminous: GetBucketCORS API returns Not Found error code when CORS configuration does not exist luminous: rgw: GetBucketCORS API returns Not Found error code when CORS configuration does not exist Apr 12, 2019
@yuriw
Copy link
Contributor

yuriw commented Jun 25, 2019

wip-yuri-testing-2019-06-25-1657-luminous

@yuriw yuriw merged commit 1cf5523 into ceph:luminous Jun 26, 2019
@smithfarm smithfarm deleted the wip-38887-luminous branch June 26, 2019 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbodley cbodley cbodley approved these changes

Assignees

@smithfarm smithfarm

Labels
luminous-batch-1 needs-qa rgw wip-yuri-testing
Projects
None yet
Milestone
luminous
5 participants
@smithfarm @vumrao @yuriw @cbodley @ashitakasam