common/blkdev: get_device_id: behave if model is lvm and id_model_enc isn't there #27156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiexingguo
reviewed
Mar 25, 2019
src/common/blkdev.cc
Outdated
| if (enc.size()) { | ||
| id_model = enc; | ||
| const char *enc = udev_device_get_property_value(dev, "ID_MODEL_ENC"); | ||
| if (cenc) { |
… isn't there If that happens, leave ID_MODEL blank and we'll fall back to something else, like ID_SERIAL (which is present in each case I've seen this). Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-futz-devid-more
branch
from
c7b4239
to
ec4434a
Compare
dillaman
approved these changes
Mar 25, 2019
|
also fixed the problem in my environment |
liewegas
added a commit
that referenced
this pull request
Mar 25, 2019
* refs/pull/27156/head: common/blkdev: get_device_id: behave if model is lvm and id_model_enc isn't there Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If that happens, leave ID_MODEL blank and we'll fall back to something
else, like ID_SERIAL (which is present in each case I've seen this).
Signed-off-by: Sage Weil sage@redhat.com