script/ceph-backport.sh: allow user to specify remote repo #27233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tchaikov
commented
Mar 28, 2019
tchaikov
commented
- References tracker ticket
- Updates documentation if necessary
- Includes tests for new functionality or reproducer for bug
* no need for checking negative numbers
* use regex for matching the number instead of using bash's pattern
matching, otherwise i have
./ceph-backport.sh: line 79: syntax error in conditional expression:
unexpected token `('
the pattern matching works fine if i use it in command line, but
it fails to work in shell script.
Signed-off-by: Kefu Chai <kchai@redhat.com>
smithfarm
reviewed
Mar 28, 2019
| # | ||
| # you can also optionally add the remote repo's name in this file, like | ||
| # | ||
| # github_repo=[your_github_repo_name] |
There was a problem hiding this comment.
Please add: If you don't add it, it will default to "origin"
There was a problem hiding this comment.
updated and repushed.
smithfarm
approved these changes
Mar 28, 2019
before this change, the script always push to "origin", in my case, "origin" points to "ceph/ceph", while we need to create the branch in private repo. and the name of private repo might vary. so would be great if we can customize this setting. Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
script/ceph-backport.sh
branch
from
d689913
to
694d159
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.