mgr/dashboard: Silence Alertmanager alerts #27277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, that's a big PR. Is it by intention that this PR contains the code of another PR (i assume it's something with the back button)? |
|
I only have the commits left that are in use to get it working in order to review the result in the first place. And I know it really big - but the most changes are tests ;) |
Devp00l
changed the title
Devp00l
force-pushed
the
wip-prometheus-silencing-current
branch
2 times, most recently
from
208776d
to
95d9879
Compare
|
jenkins retest this please |
Devp00l
force-pushed
the
wip-prometheus-silencing-current
branch
from
95d9879
to
33b5add
Compare
Devp00l
changed the title
Devp00l
force-pushed
the
wip-prometheus-silencing-current
branch
2 times, most recently
from
f51039d
to
ea583cd
Compare
LenzGr
changed the title
Devp00l
force-pushed
the
wip-prometheus-silencing-current
branch
from
ea583cd
to
b29ea41
Compare
|
jenkins retest this please |
|
Great work! Just 1 observation: |
|
retest this please |
callithea
reviewed
May 23, 2019
callithea
reviewed
May 23, 2019
doc/mgr/dashboard.rst
Outdated
| @@ -523,18 +524,28 @@ twice if you use both sources. | |||
| configuration checkout the `<http_config> documentation | |||
| <https://prometheus.io/docs/alerting/configuration/#%3Chttp_config%3E>`_. | |||
|
|
|||
| #. Use the API of the Prometheus Alertmanager | |||
| #. Use the API of the Prometheus and Alertmanager | |||
There was a problem hiding this comment.
Suggested change
| #. Use the API of the Prometheus and Alertmanager | |
| #. Use the API of Prometheus and the Alertmanager |
Devp00l
force-pushed
the
wip-prometheus-silencing-current
branch
2 times, most recently
from
5be4787
to
598c12e
Compare
|
jenkins test make check |
tspmelo
suggested changes
Jul 1, 2019
...gr/dashboard/frontend/src/app/ceph/cluster/prometheus/silence-list/silence-list.component.ts
Show resolved
Hide resolved
...gr/dashboard/frontend/src/app/ceph/cluster/prometheus/silence-list/silence-list.component.ts
Outdated
Show resolved
Hide resolved
...nd/mgr/dashboard/frontend/src/app/ceph/cluster/prometheus/alert-list/alert-list.component.ts
Outdated
Show resolved
Hide resolved
src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.html
Show resolved
Hide resolved
tspmelo
reviewed
Jul 1, 2019
src/pybind/mgr/dashboard/frontend/src/app/shared/datatable/table/table.component.spec.ts
Outdated
Show resolved
Hide resolved
2 tasks
Succeeded action labels can be used in order to show the right tense for a succeeded action in a success notification. Fixes: https://tracker.ceph.com/issues/36722 Signed-off-by: Stephan Müller <smueller@suse.com>
Devp00l
force-pushed
the
wip-prometheus-silencing-current
branch
2 times, most recently
from
340cf0a
to
455a7fe
Compare
|
Addressed all comments :) |
|
Please run |
added 4 commits
July 4, 2019 16:19
Now you can silence alerts through the dashboard. You can now create, recreate, edit and expire a silence. You can create a silence based on a selected alert. The silence form will help you create a silence that silences an alert. It is provided with functionality to check if the silences, that you are about to create, will or will not match an active alert or even a rule. It also provides help choosing the right values for the right chosen matcher attribute name, through the use of type ahead values. The dashboard will now use the Prometheus and the Alertmanager API Fixes: https://tracker.ceph.com/issues/36722 Signed-off-by: Stephan Müller <smueller@suse.com>
It's now easy to deal with unset settings. Fixes: https://tracker.ceph.com/issues/36722 Signed-off-by: Stephan Müller <smueller@suse.com>
Currently it's not easily possible to mock a selection during table action tests, that's why I added a method that is used to create the selection that is used through out the table action scenario tests. You can simply overwrite it to get a different base object as selection. Fixes: https://tracker.ceph.com/issues/36722 Signed-off-by: Stephan Müller <smueller@suse.com>
The time diff service can easily calculate the difference between two dates and print it out in a human readable duration format. It also can calculate a end or start date based on a date and a duration string. Fixes: https://tracker.ceph.com/issues/36722 Signed-off-by: Stephan Müller <smueller@suse.com>
Devp00l
force-pushed
the
wip-prometheus-silencing-current
branch
from
455a7fe
to
3fb21de
Compare
|
Addressed all comments and using the icons enum now. |
tspmelo
approved these changes
Jul 5, 2019
|
jenkins test dashboard |
votdev
approved these changes
Jul 5, 2019
|
jenkins test dashboard |
1 similar comment
|
jenkins test dashboard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now you can silence alerts through the dashboard. You can now create,
recreate, edit and expire a silence. You can create a silence based on a
selected alert.
The silence form will help you create a silence that silences an alert.
It is provided with functionality to check if the silences, that
you are about to create, will or will not match an active alert or even
a rule.
It also provides help choosing the right values for the right chosen
matcher attribute name, through the use of type ahead values.
The dashboard will now use the Prometheus and the Alertmanager API
Fixes: https://tracker.ceph.com/issues/36722
Signed-off-by: Stephan Müller smueller@suse.com
This PR can be merged after #27274. It is not directly related but will cause merge conflicts.