qa: fs/upgrade test fixes and cephfs feature bit updates for Octopus/Nautilus #27303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ukernel
reviewed
Apr 2, 2019
src/mds/cephfs_features.h
Outdated
| @@ -27,6 +27,8 @@ | |||
| #define CEPHFS_FEATURE_RECLAIM_CLIENT 10 | |||
| #define CEPHFS_FEATURE_LAZY_CAP_WANTED 11 | |||
| #define CEPHFS_FEATURE_MULTI_RECONNECT 12 | |||
| /* N.B.: oops, we can't use CEPHFS_FEATURE_NAUTILUS because we didn't add a bit for it. */ | |||
| #define CEPHFS_FEATURE_NAUTILUS Ooops | |||
There was a problem hiding this comment.
"Oops" is just a placeholder since it cannot be used.
ukernel
reviewed
Apr 2, 2019
Direct upgrades from Luminous to Octopus are not supported. These snap format upgrade tests are now only going to be run in the mimic/nautilus branches. Fixes: http://tracker.ceph.com/issues/39020 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Fixes: http://tracker.ceph.com/issues/39020 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Fixes: http://tracker.ceph.com/issues/39078 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Fixes: http://tracker.ceph.com/issues/39077 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
|
LGTM |
|
Please approve then @ukernel (github checks prevent merges without one). |
|
|
batrick
added a commit
that referenced
this pull request
Apr 4, 2019
* refs/pull/27303/head: mds: add Octopus cephfs feature bit mds: verify current release has a cephfs feature bit mds: add cephfs feature bit for Nautilus mon: generalize and refactor lambda use qa: test featureful client with mimic base qa: remove obsolete snap upgrade tests Reviewed-by: Zheng Yan <zyan@redhat.com>
|
(I forced the merge by editing GitHub protection rules.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.