nautilus: mgr/pg_autoscaler: add pg_autoscale_bias #27387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit f845fa1)
Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit f1d3be6)
This is a relatively naive way to apply the bias: we just multiply it to whatever we would have chosen. A more clever approach would be to factor this into the overall cluster-wide PG budget, so that biasing one pool's PGs up would put downward pressure on other pools. That is significantly more complicated, however, and (I think) not worth the effort. Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit e7ad0ee)
liewegas
requested review from
badone and
xiexingguo
and removed request for
badone
neha-ojha
approved these changes
Apr 4, 2019
xiexingguo
approved these changes
Apr 8, 2019
liewegas
added a commit
that referenced
this pull request
Apr 10, 2019
* refs/pull/27387/head: mgr/pg_autoscaler: apply bias to pg_num selection mgr/pg_autoscaler: include pg_autoscale_bias in autoscale-status table osd/osd_types,mon: add pg_autoscale_bias pool property Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn> Reviewed-by: Neha Ojha <nojha@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #27154