nautilus: osd: OSDMapRef access by multiple threads is unsafe #27402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we update OSD::osdmap in OSD::_committed_osd_maps() which is executed by objectstore's finisher thread. while PG::sched_scrub() is called by OSD's sharded work queue's worker thread.and we push the osdmap updates down to PGs OSD::consume_map() which is in turn called by OSD::_committed_osd_maps() where osdmap is updated. so it does not big deal if we are checking a stale CEPH_OSDMAP_NODEEP_SCRUB flag. also this flag will be updated with the latest osdmap very soon. Signed-off-by: Kefu Chai <kchai@redhat.com> Signed-off-by: Zengran Zhang <zhangzengran@sangfor.com.cn> (cherry picked from commit 454c4cb) # Conflicts: # src/osd/OSD.cc - trivial conflict from adjacent code in OSDService::shutdown()
tchaikov
approved these changes
Apr 7, 2019
liewegas
added a commit
that referenced
this pull request
Apr 10, 2019
* refs/pull/27402/head: OSD: OSDMapRef access by multiple threads is unsafe Reviewed-by: Kefu Chai <kchai@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we update OSD::osdmap in OSD::_committed_osd_maps() which is executed
by objectstore's finisher thread. while PG::sched_scrub() is called
by OSD's sharded work queue's worker thread.and we push the osdmap
updates down to PGs OSD::consume_map() which is in turn called by
OSD::_committed_osd_maps() where osdmap is updated. so it does not big
deal if we are checking a stale CEPH_OSDMAP_NODEEP_SCRUB flag.
also this flag will be updated with the latest osdmap very soon.
Signed-off-by: Kefu Chai kchai@redhat.com
Signed-off-by: Zengran Zhang zhangzengran@sangfor.com.cn
(cherry picked from commit 454c4cb)