nautilus: osd/PG: discover missing objects when an OSD peers and PG is degraded #27744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a PG is remapped from OSD `a` to OSD `b`, the objects are backfilled. When OSD `a` is restarted, objects become degraded as `a` is no longer queried or considered as a backfill source. As the PG is degraded, `PG::discover_all_missing` is not called when a candidate OSD peers with the primary: The PG is already active, thus `PG::activate` (and in turn missing object discovery) is not called. Discovery is also not initiated from `PG::RecoveryState::Active::react(const MNotifyRec& notevt)` as there are no unfound objects. This patch adds a call to `discover_all_missing` when when an OSD sends its `MNotifyRec` message and the PG is degraded. Fixes: https://tracker.ceph.com/issues/37439 Signed-off-by: Jonas Jelten <jj@stusta.net> (cherry picked from commit e152d09)
|
jenkins test docs |
1 task
|
Just to make sure this lands in the next nautilus release, is there something holding back the patch? If yes, I'm ready to help out. |
|
jenkins retest this please |
neha-ojha
approved these changes
May 18, 2019
|
@TheJJ It is not building properly for the Jenkins "make check" test, but this is currently happening in other nautilus PRs as well. Anyway, you shouldn't worry - the PR will get into an integration testing run in due course. |
|
jenkins re-test this please |
|
jenkins test docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tracker.ceph.com/issues/39432