mimic: mgr/dashboard: Improve error message when backend is unreachable #27748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation of the HTTP interceptor does not use the error description in all cases. Fixes: https://tracker.ceph.com/issues/36190 Signed-off-by: Volker Theile <vtheile@suse.com> (cherry picked from commit 7d41a4a)
|
Make check is failing because the You have to fix the import manually or backport #22857 before this one. |
It seems, that the file does not exist in Mimic. I'm going to put the imports and providers in the beforeEach block. This should resolve the problem. |
Do not import the unit-test-helper, since the file doesn't exist in mimic. Instead the compilation of the imports and provider will be done in a beforeEach block Signed-off-by: Sebastian Krah <skrah@suse.com>
|
I wonder if it would make sense to backport #22857 in order to make it easier for frontend PRs to be backported without having to make changes. @ricardoasmarques or @tspmelo - what do you think? |
|
@LenzGr I created http://tracker.ceph.com/issues/39941 to track the backport of #22857 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/36334