rgw: add some comments to rgw code to help explain functionality #27896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this PR only touches comments, as long as it compiles it should not change behavior. Therefore I believe a shaman build is sufficient. See: https://shaman.ceph.com/builds/ceph/wip-add-rgw-period-comments/ |
|
@cbodley Since my understanding of RGWPeriod comes from my conversation with you, I wanted to make sure I captured it well enough. Please feel free to suggest improvements and corrections. Thanks! |
cbodley
reviewed
May 2, 2019
ivancich
force-pushed
the
wip-add-rgw-period-comments
branch
from
24d9505
to
c7c25cc
Compare
Comments to explain the role of RGWPeriod and the use of prefixes in gc log entries are added. Some other comments are reformatted for 80 columns. Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
ivancich
force-pushed
the
wip-add-rgw-period-comments
branch
from
c7c25cc
to
8111dd7
Compare
cbodley
approved these changes
May 3, 2019
|
You're welcome, @cbodley. I would like (us) to keep nibbling away at this stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments to explain the role of RGWPeriod and the use of prefixes in gc log entries are added. Some other comments are reformatted for 80 columns.