osd/PG: fix cleanup of pgmeta-like objects on PG deletion; disallow empty object names #27929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdurgin
reviewed
May 2, 2019
| @@ -1858,6 +1858,11 @@ void PrimaryLogPG::do_op(OpRequestRef& op) | |||
| osd->reply_op_error(op, -ENAMETOOLONG); | |||
| return; | |||
| } | |||
| if (m->get_hobj().oid.name.empty()) { | |||
| dout(4) << "do_op empty oid name is not allowed" << dendl; | |||
There was a problem hiding this comment.
should we include a cluster log here so that we catch it if rgw/rbd/cephfs does this during testing?
jdurgin
approved these changes
May 2, 2019
neha-ojha
approved these changes
May 2, 2019
If an object has an empty 'name' field, it "looks" like a pgmeta object, and the PG cleanup code was skipping it. However, we were letting these objects get created. Fix by only skipping *our* pgmeta object. If there are other pgmeta-like objects in the PG collection, clean them up. Fixes: https://tracker.ceph.com/issues/38724 Signed-off-by: Sage Weil <sage@redhat.com>
These may conflict with pgmeta objects. And are going to cause other problems later (e.g., https://tracker.ceph.com/issues/38724). Signed-off-by: Sage Weil <sage@redhat.com>
This is always a bug (OSD doesn't try to remove a collection unless it thinks it is empty), and not seeing it at default debug levels makes it hard to track down. Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
added a commit
that referenced
this pull request
May 7, 2019
* refs/pull/27929/head: os/bluestore: be verbose about objects that existing on rmcoll osd/PrimaryLogPG: disallow ops on objects with an empty name osd/PG: fix cleanup of pgmeta-like objects on PG deletion Reviewed-by: Josh Durgin <jdurgin@redhat.com> Reviewed-by: Neha Ojha <nojha@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tracker.ceph.com/issues/38724