Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rgw/pubsub: fix doc on updates. fix multi-notifications #27931

Merged
merged 4 commits into from May 7, 2019
Merged

rgw/pubsub: fix doc on updates. fix multi-notifications #27931

merged 4 commits into from May 7, 2019

Conversation

yuvalif
Copy link
Contributor

@yuvalif yuvalif commented May 2, 2019 •
edited

Signed-off-by: Yuval Lifshitz yuvalif@yahoo.com

  • This PR is clarifying how updates to topics and notifications work. Also, adding tests that verify this behavior. Note that currently the tests has manual steps, hence they are skipped
  • This PR also address the case where multiple notifications are allowed in one XML payload of the S3-compliant notification creation API. Matching test: test_ps_s3_multiple_topics_notification() is added

@yuvalif
rgw/pubsub: fix doc on updates. attempt to fix multi-notifications
3279a78 
Signed-off-by: Yuval Lifshitz <yuvalif@yahoo.com>
@yuvalif yuvalif requested review from yehudasa and cbodley May 2, 2019 17:47
cbodley and others added 2 commits May 5, 2019 10:06
@cbodley @yuvalif
rgw: RGWUserPubSub::write invalidates its obj_ctx
c0b9d10 
Signed-off-by: Casey Bodley <cbodley@redhat.com>
@yuvalif
rgw/pubsub: cleanup tests for multiple notifications
b4005db 
Signed-off-by: Yuval Lifshitz <yuvalif@yahoo.com>
@yuvalif yuvalif changed the title [WIP] rgw/pubsub: fix doc on updates. attempt to fix multi-notifications rgw/pubsub: fix doc on updates. fix multi-notifications May 5, 2019
@yuvalif yuvalif removed the DNM label May 5, 2019
cbodley
cbodley reviewed May 6, 2019
View reviewed changes
src/rgw/rgw_tools.h Outdated Show resolved Hide resolved
@yuvalif
rgw/pubsub: revert the RGWSysObjectCtx change
10b8b57 
Signed-off-by: Yuval Lifshitz <yuvalif@yahoo.com>
@yuvalif yuvalif merged commit 2d410b5 into ceph:master May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbodley cbodley cbodley approved these changes

@yehudasa yehudasa Awaiting requested review from yehudasa

Assignees
No one assigned
Labels
bug-fix rgw
Projects
None yet
Milestone
No milestone
2 participants
@yuvalif @cbodley