luminous: osd: Include dups in copy_after() and copy_up_to() #28185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Zafman <dzafman@redhat.com> (cherry picked from commit d1ad129) Conflicts: src/osd/osd_types.cc (trivial)
Move log message out of loop so it doesn't repeat for no reason Signed-off-by: David Zafman <dzafman@redhat.com> (cherry picked from commit b698e34)
Client saw out of order results in a test with a very small pg_log because a backfill/recovery sent a small number of log entries for duplicate checks. Since these copy operations are equivalent to both a copy and trim (an argument controls how many log entries transfer), we need to include any new dups with enough existing dups up to the configured maximum. Fixes: http://tracker.ceph.com/issues/39304 Signed-off-by: David Zafman <dzafman@redhat.com> (cherry picked from commit 00f279d) Conflicts: src/osd/PeeringState.cc contents in src/osd/PG.cc src/osd/osd_types.cc (trivial)
Signed-off-by: David Zafman <dzafman@redhat.com> (cherry picked from commit 7959159)
osd_min_pg_log_entries and osd_max_pg_log_entries are not involved in the log handling code being tested. Signed-off-by: David Zafman <dzafman@redhat.com> (cherry picked from commit a008bd8) Conflicts: src/test/osd/TestPGLog.cc (trivial)
…copy_after Signed-off-by: David Zafman <dzafman@redhat.com> (cherry picked from commit d0d244d)
The log tail is not inclusive of the log, so not an overlap Fix unittest_pglog to verify proper operation Signed-off-by: David Zafman <dzafman@redhat.com> (cherry picked from commit f526c6d)
jdurgin
approved these changes
May 28, 2019
athanatos
approved these changes
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tracker.ceph.com/issues/39719