mimic: osd: Don't include user changeable flag in snaptrim related assert #28202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caused by: a53ba73 Fixes: http://tracker.ceph.com/issues/38124 Signed-off-by: David Zafman <dzafman@redhat.com> (cherry picked from commit 63c2060) Conflicts: src/osd/PrimaryLogPG.h (Use assert() in mimic)
|
This backport look ok to me, but did we fix the underlying race? |
athanatos
approved these changes
May 22, 2019
|
@athanatos I considered it a race with the assert. I assumed that if snap trim got as far as WaitReservation::react(const SnapTrimReserved&), can_trim() includes nosnaptrim and wouldn't proceed. Before nosnaptrim was added, the assert was correct. But afterwards the assert raced with the user setting nosnaptrim. |
|
Ah, so setting CEPH_OSDMAP_NOSNAPTRIM doesn't necessarily cancel an in-progress trim. Ok, LGTM. |
neha-ojha
approved these changes
Jun 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/39698